Automatic tracing for Jobs defined in quartz-jobs dependency#1170
Merged
eyalkoren merged 2 commits intoelastic:masterfrom May 7, 2020
Merged
Automatic tracing for Jobs defined in quartz-jobs dependency#1170eyalkoren merged 2 commits intoelastic:masterfrom
eyalkoren merged 2 commits intoelastic:masterfrom
Conversation
💚 Build SucceededExpand to view the summary
Build stats
Test stats 🧪
|
Contributor
|
Looks good! Thanks @theobisproject! |
Contributor
Author
|
I will update both. Should the sentence for the CHANGELOG be in the |
965f78a to
683bde1
Compare
eyalkoren
approved these changes
May 7, 2020
...-plugin/src/main/java/co/elastic/apm/agent/quartz/job/JobTransactionNameInstrumentation.java
Show resolved
Hide resolved
felixbarny
approved these changes
May 7, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
While going through our traced Quartz schedules I noticed that the directory scanning schedules are missing which we implement via quartz-jobs artifact of the quartz project.
In this use case we do not implement a quartz job but only a callback interface the job will call. As described in the documentation I would have to add the
org.quartz.jobspackage currently to theapplication_packagesto make this work.In my opinion it would be more user friendly when the jobs provided by the quartz project would work without extra configuration.
This PR add's the instrumentation of the job from the
quartz-jobsdependency. I decided to not add the package name to theapplicationPackagescollection because the collection we get is immutable.Checklist
Author's Checklist
Related issues
Use cases
The
quartz-jobsdependency provides ready to use jobs for the following use-casesScreenshots