Skip to content

Add support for Azure App Service cloud metadata#914

Merged
axw merged 5 commits intoelastic:masterfrom
axw:cloud-metadata-azureappservice
Mar 17, 2021
Merged

Add support for Azure App Service cloud metadata#914
axw merged 5 commits intoelastic:masterfrom
axw:cloud-metadata-azureappservice

Conversation

@axw
Copy link
Copy Markdown
Member

@axw axw commented Mar 15, 2021

Extend the Azure cloud metadata provider to check for App Service environment variables, and implement the Gherkin spec.

Closes #863

@ghost
Copy link
Copy Markdown

ghost commented Mar 15, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #914 updated

  • Start Time: 2021-03-15T02:53:11.845+0000

  • Duration: 33 min 11 sec

  • Commit: 5340e7c

Test stats 🧪

Test Results
Failed 0
Passed 9953
Skipped 266
Total 10219

Trends 🧪

Image of Build Times

Image of Tests

@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #914 (5340e7c) into master (a83b7ed) will decrease coverage by 0.11%.
The diff coverage is 62.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #914      +/-   ##
==========================================
- Coverage   83.93%   83.82%   -0.12%     
==========================================
  Files         140      140              
  Lines        7864     7895      +31     
==========================================
+ Hits         6601     6618      +17     
- Misses        867      876       +9     
- Partials      396      401       +5     
Impacted Files Coverage Δ
internal/apmcloudutil/azure.go 70.49% <60.00%> (-10.16%) ⬇️
apmtest/env.go 100.00% <100.00%> (ø)
profiling.go 71.92% <0.00%> (-7.02%) ⬇️
tracer.go 88.58% <0.00%> (+0.30%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a83b7ed...5340e7c. Read the comment docs.

@axw axw marked this pull request as ready for review March 15, 2021 03:39
@axw axw requested a review from a team March 15, 2021 03:39
Copy link
Copy Markdown
Contributor

@stuartnelson3 stuartnelson3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving as everything looks fine, but with the caveat that I'm not familiar with the codebase :)

@axw
Copy link
Copy Markdown
Member Author

axw commented Mar 17, 2021

Approving as everything looks fine, but with the caveat that I'm not familiar with the codebase :)

@stuartnelson3 I'll walk you through this codebase sometime soonish. Thanks for the review!

@axw axw merged commit df272e4 into elastic:master Mar 17, 2021
@axw axw deleted the cloud-metadata-azureappservice branch March 17, 2021 11:48
stuartnelson3 pushed a commit that referenced this pull request Jul 30, 2021
* test: synchronizing gherkin specs

* Add support for Azure App Service cloud metadata

* internal/apmgodog: move code to to _test package

Co-authored-by: apmmachine <infra-root-apmmachine@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[META 388] Collect Azure App Service cloud metadata

4 participants