Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove coverage ci check #1693

Merged
merged 1 commit into from
Feb 28, 2025
Merged

Remove coverage ci check #1693

merged 1 commit into from
Feb 28, 2025

Conversation

dmathieu
Copy link
Member

This check has been failing for months.
Its usefulness is also very limited, as the coverage results aren't sent anywhere, they're only displayed in the log output, making the data impossible to use in the current state.

@dmathieu dmathieu marked this pull request as ready for review February 28, 2025 09:27
@dmathieu dmathieu requested a review from a team as a code owner February 28, 2025 09:27
rockdaboot
rockdaboot approved these changes Feb 28, 2025
View reviewed changes
Copy link
Contributor

@rockdaboot rockdaboot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that since the project is in maintenance mode, we don't need this check any more.

@dmathieu dmathieu enabled auto-merge (squash) February 28, 2025 11:08
@rockdaboot rockdaboot self-requested a review February 28, 2025 11:39
@dmathieu dmathieu merged commit c9f2257 into main Feb 28, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rockdaboot rockdaboot rockdaboot approved these changes

Assignees
No one assigned
Labels
agent-go
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dmathieu @rockdaboot