Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support go-redis v9 #1413

Closed
wants to merge 1 commit into from
Closed

feat: support go-redis v9 #1413

wants to merge 1 commit into from

Conversation

wzy9607
Copy link

@wzy9607 wzy9607 commented Apr 16, 2023

go-redis has recently released v9 version, this pull request adds instrumentation support for it.

@cla-checker-service
Copy link

cla-checker-service bot commented Apr 16, 2023

💚 CLA has been signed

@wzy9607 wzy9607 closed this Apr 16, 2023
@wzy9607 wzy9607 reopened this Apr 16, 2023
@dmathieu
Copy link
Member

Note: the next release of the agent will include an apmotel package (and traces coming soon).

This means any OpenTelemetry instrumentation package will be supported as well. So the package provided by go-redis themselves would be a good replacement for the instrumentation in here.
https://github.com/redis/go-redis/tree/master/extra/redisotel

// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
// KIND, either express or implied. See the License for the
// specific language governing permissions and limitations
// under the License.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As goredis doesn't support older versions of Go, you should add a build tag to prevent building with those non-supported versions.

//go:build go1.18

In every file, except in doc.go, so there's at least one built file in the package.

@wzy9607
Copy link
Author

wzy9607 commented Apr 22, 2023

Note: the next release of the agent will include an apmotel package (and traces coming soon).

This means any OpenTelemetry instrumentation package will be supported as well. So the package provided by go-redis themselves would be a good replacement for the instrumentation in here. https://github.com/redis/go-redis/tree/master/extra/redisotel

Thanks.
I wasn't aware of goredis's otel support. After examing what redisotel provides, I think it's indeed a good replacement for this pull request. I will close this pr in favor of #1410 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants