Fix the CaptureBody in AspNetCore#2623
Merged
Merged
Conversation
Fix the CaptureBody in AspNetCore. Related to the issue #2029
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
11687b1 to
a1f2f44
Compare
stevejgordon
requested changes
Aug 12, 2025
Contributor
stevejgordon
left a comment
There was a problem hiding this comment.
Thanks @JeremyBessonElastic. A few possible changes. Also, are we able to add/update a test/integration test for ASP.NET Core to validate this and avoid future regressions?
Add integration tests
Contributor
Author
I have added integration tests for the 8 cases: |
Contributor
stevejgordon
left a comment
There was a problem hiding this comment.
Thanks for updating and adding the tests. A couple of small nits for consistency and I think we're good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the CaptureBody in AspNetCore.
Related to the issue #2029