[META 388] Add support for Azure App Service Cloud metadata#1083
Merged
russcam merged 2 commits intoelastic:masterfrom Dec 16, 2020
Merged
[META 388] Add support for Azure App Service Cloud metadata#1083russcam merged 2 commits intoelastic:masterfrom
russcam merged 2 commits intoelastic:masterfrom
Conversation
This commit adds support for retrieving cloud metadata about an Azure App Service from the environment variables.
Codecov Report
@@ Coverage Diff @@
## master #1083 +/- ##
==========================================
- Coverage 79.02% 78.97% -0.06%
==========================================
Files 149 151 +2
Lines 7362 7449 +87
==========================================
+ Hits 5818 5883 +65
- Misses 1544 1566 +22
Continue to review full report at Codecov.
|
💔 Tests Failed
Expand to view the summary
Build stats
Test stats 🧪
Test errors
Expand to view the tests failures
|
gregkalapos
approved these changes
Dec 9, 2020
Contributor
gregkalapos
left a comment
There was a problem hiding this comment.
LGTM 👍
1 small thing below.
8 tasks
Contributor
Author
|
failing test is unrelated to this change: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds support for retrieving cloud metadata about an Azure App Service from the environment variables.