Skip to content
This repository was archived by the owner on Jun 24, 2022. It is now read-only.

idempotently wait for native realm to come up#831

Merged
jmlrt merged 3 commits into
elastic:mainfrom
gaima8:idempotentsleep
Dec 8, 2021
Merged

idempotently wait for native realm to come up#831
jmlrt merged 3 commits into
elastic:mainfrom
gaima8:idempotentsleep

Conversation

@gaima8
Copy link
Copy Markdown
Contributor

@gaima8 gaima8 commented Oct 23, 2021

command necessarily causes a change on each invocation breaking idempotency, wait_for accomplishes the same goal without the change

@gaima8
command necessarily causes a change on each invocation breaking idemp…
b1db566 
…otency, wait_for accomplishes the same goal without the change
@elasticmachine
Copy link
Copy Markdown
Collaborator

elasticmachine commented Oct 23, 2021

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

3 similar comments
@elasticmachine
Copy link
Copy Markdown
Collaborator

elasticmachine commented Oct 23, 2021

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@elasticmachine
Copy link
Copy Markdown
Collaborator

elasticmachine commented Oct 23, 2021

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@elasticmachine
Copy link
Copy Markdown
Collaborator

elasticmachine commented Oct 23, 2021

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@cla-checker-service
Copy link
Copy Markdown

cla-checker-service Bot commented Oct 23, 2021 •
edited
Loading

💚 CLA has been signed

@gaima8
Copy link
Copy Markdown
Contributor Author

gaima8 commented Oct 31, 2021

I filled in the thing. Shouldn't the bot have done something by now?

jmlrt
jmlrt approved these changes Dec 8, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@jmlrt jmlrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM⛴

@jmlrt
Copy link
Copy Markdown
Member

jmlrt commented Dec 8, 2021

jenkins test this please

@jmlrt jmlrt merged commit 90ecd51 into elastic:main Dec 8, 2021
@gaima8 gaima8 deleted the idempotentsleep branch January 30, 2022 20:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@jmlrt jmlrt jmlrt approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@gaima8 @elasticmachine @jmlrt