Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding config file option for create nodegroup #553

Merged
merged 11 commits into from
Feb 20, 2019
Merged

Adding config file option for create nodegroup #553

merged 11 commits into from
Feb 20, 2019

Conversation

jrryjcksn
Copy link
Contributor

@jrryjcksn jrryjcksn commented Feb 18, 2019 •
edited
Loading

Description

Allow a user to pass a config file when creating nodegroups (via --config-file or -f) and select particular nodegroups from the file (via --only or -o ).

Checklist

  • Code compiles correctly (i.e make build)
  • Added tests that cover your change (if possible)
  • All unit tests passing (i.e. make test)
  • All integration tests passing (i.e. make integration-test)
  • Added/modified documentation as required (such as the README.md, and examples directory)
  • Added yourself to the humans.txt file

@jrryjcksn jrryjcksn self-assigned this Feb 18, 2019
D3nn
D3nn reviewed Feb 18, 2019
View reviewed changes
palemtnrider
palemtnrider reviewed Feb 18, 2019
View reviewed changes
Copy link
Contributor

@palemtnrider palemtnrider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good and complete. Just a few questions/comments

palemtnrider
palemtnrider reviewed Feb 19, 2019
View reviewed changes
Copy link
Contributor

@palemtnrider palemtnrider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some info messages coming from cfn/builder/nodegroup.go that could benefit from additional logging values - i.e. the nodegroup name. Here is what is output:

ℹ]  creating nodegroup stack "eksctl-pmr-ngtest-nodegroup-pmr-ngtest-ng-3"
[ℹ]  creating nodegroup stack "eksctl-pmr-ngtest-nodegroup-pmr-ngtest-ng-1"
[ℹ]  creating nodegroup stack "eksctl-pmr-ngtest-nodegroup-pmr-ngtest-ng-2"
[ℹ]  --nodes-min=1 was set automatically
[ℹ]  --nodes-max=1 was set automatically
[ℹ]  --nodes-min=1 was set automatically
[ℹ]  --nodes-max=1 was set automatically
[ℹ]  --nodes-min=1 was set automatically
[ℹ]  --nodes-max=1 was set automatically

errordeveloper
errordeveloper reviewed Feb 19, 2019
View reviewed changes
@jrryjcksn
Copy link
Contributor Author

delete nodegroup allows the nodegroup name to be specified either directly:
eksctl delete nodegroup <name> --cluster=<cluster name>... or via a flag:
eksctl delete nodegroup --name=<name> --cluster=<cluster name>

The docs are not consistent. The README.md calls out the latter, the message given in create when an error occurs suggests the former. Do we want to change this so that there is only one way (and, if so, which way?)

@palemtnrider
Copy link
Contributor

my .02 on delete nodegroup <name> vs --name is the former seems more natural to me.

@jrryjcksn jrryjcksn force-pushed the allow_config_file_for_create_nodegroup branch from 8e2ee7a to 00eb146 Compare February 19, 2019 15:48
@jrryjcksn jrryjcksn changed the title WIP - Initial pass at adding config file option for create nodegroup Adding config file option for create nodegroup Feb 19, 2019
palemtnrider
palemtnrider previously approved these changes Feb 19, 2019
View reviewed changes
Copy link
Contributor

@palemtnrider palemtnrider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job Jerry. Builds and works as expected and documented.

mumoshu
mumoshu previously approved these changes Feb 20, 2019
View reviewed changes
Copy link
Contributor

@mumoshu mumoshu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't wish more than this for the first implementation! Clean and complete, well-documented. I'm impressed to your job @jrryjcksn ☺️

rade
rade reviewed Feb 20, 2019
View reviewed changes
README.md Outdated
@@ -185,6 +192,20 @@ To create an additional nodegroup, use:
eksctl create nodegroup --cluster=<clusterName> [--name=<nodegroupName>]
```

Additionally, you can use the same config file used for create
cluster:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should probably be create cluster or eksctl create cluster.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, okay

@jrryjcksn jrryjcksn dismissed stale reviews from mumoshu and palemtnrider via 36bfe01 February 20, 2019 14:50
errordeveloper
errordeveloper previously approved these changes Feb 20, 2019
View reviewed changes
Copy link
Contributor

@errordeveloper errordeveloper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just needs a rebase and then we can merge.

@jrryjcksn jrryjcksn force-pushed the allow_config_file_for_create_nodegroup branch from 36bfe01 to f228028 Compare February 20, 2019 15:07
errordeveloper
errordeveloper approved these changes Feb 20, 2019
View reviewed changes
Copy link
Contributor

@errordeveloper errordeveloper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jrryjcksn please merge!

@jrryjcksn jrryjcksn merged commit ead2b2a into master Feb 20, 2019
@jrryjcksn jrryjcksn deleted the allow_config_file_for_create_nodegroup branch February 20, 2019 16:06
This was referenced Feb 21, 2019
Closed
Closed
@errordeveloper errordeveloper mentioned this pull request Mar 27, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rade rade rade left review comments

@D3nn D3nn D3nn left review comments

@errordeveloper errordeveloper errordeveloper approved these changes

@mumoshu mumoshu mumoshu left review comments

@palemtnrider palemtnrider palemtnrider left review comments

Assignees

@jrryjcksn jrryjcksn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@jrryjcksn @palemtnrider @mumoshu @rade @errordeveloper @D3nn @weave-e2e-quickstart