Support public/private API endpoints settings from file

[ota42y]

Description

update-cluster-endpoints command changes API endpoint settings (#1149)

But this command doesn't read config file.
So when we use -f option, eksctl doesn't change settings.

Checklist

• Added tests that cover your change (if possible)
• Added/modified documentation as required (such as the README.md, and examples directory)
• Manually tested
• Added labels for change area (e.g. area/nodegroup) and target version (e.g. version/0.12.0)
• Added note in docs/release_notes/draft.md (or relevant release note)

[ota42y]

@weaveworks/eksctl
I add changes and manually tested.
Do I need to add more tests and where to add tests ?

I got error in circleci but I think this isn't from my changes 🤔
In my PC, all test passed.

mkdir -p vendor/github.com/aws/
ln -sfn "/go/pkg/mod/github.com/weaveworks/[email protected]" vendor/github.com/aws/aws-sdk-go
time env GOBIN=/go/bin go generate ./pkg/eks/mocks
Unable to find CloudFormationAPI in any go files under this path
pkg/eks/mocks/mocks.go:16: running "/go/bin/mockery": exit status 1
Command exited with non-zero status 1
real	0m 0.19s
user	0m 0.23s
sys	0m 0.09s
make[1]: *** [Makefile:180: pkg/eks/mocks/SSMAPI.go] Error 1
make[1]: Leaving directory '/src'
make: *** [Makefile:85: test] Error 2

[martina-if]

Thanks @ota42y ! Looks good. I added a minor comment. Can you also rebase the branch?

[ota42y]

I finished rebase!

[martina-if]

I ran some manual tests and it seems to be working well:

---
apiVersion: eksctl.io/v1alpha5
kind: ClusterConfig

metadata:
  name: martina-test-priv-ep
  region: eu-north-1

nodeGroups:
  - name: ng-1
    instanceType: m5.large
    desiredCapacity: 1

vpc:
  clusterEndpoints:
    publicAccess: true
    privateAccess: true

./eksctl utils update-cluster-endpoints  -f examples/01-simple-cluster.yaml 
[ℹ]  using region eu-north-1
[ℹ]  current Kubernetes API endpoint access: privateAccess=false, publicAccess=true
[ℹ]  (plan) would update Kubernetes API endpoint access for cluster "martina-test-priv-ep" in "eu-north-1" to: privateAccess=true, publicAccess=true
[!]  no changes were applied, run again with '--approve' to apply the changes

 ./eksctl utils update-cluster-endpoints  -f examples/01-simple-cluster.yaml  --approve
[ℹ]  using region eu-north-1
[ℹ]  current Kubernetes API endpoint access: privateAccess=false, publicAccess=true
[ℹ]  will update Kubernetes API endpoint access for cluster "martina-test-priv-ep" in "eu-north-1" to: privateAccess=true, publicAccess=true
[✔]  the Kubernetes API endpoint access for cluster "martina-test-priv-ep" in "eu-north-1" has been updated to: privateAccess=true, publicAccess=true

$ ./eksctl  utils update-cluster-endpoints --name=martina-test-priv-ep --private-access=false --public-access=true
Flag --name has been deprecated, use --cluster
[ℹ]  using region eu-north-1
[ℹ]  current Kubernetes API endpoint access: privateAccess=true, publicAccess=true
[ℹ]  (plan) would update Kubernetes API endpoint access for cluster "martina-test-priv-ep" in "eu-north-1" to: privateAccess=false, publicAccess=true
[!]  no changes were applied, run again with '--approve' to apply the changes

./eksctl  utils update-cluster-endpoints --name=martina-test-priv-ep --private-access=false --public-access=true --approve
Flag --name has been deprecated, use --cluster
[ℹ]  using region eu-north-1
[ℹ]  current Kubernetes API endpoint access: privateAccess=true, publicAccess=true
[ℹ]  will update Kubernetes API endpoint access for cluster "martina-test-priv-ep" in "eu-north-1" to: privateAccess=false, publicAccess=true
[✔]  the Kubernetes API endpoint access for cluster "martina-test-priv-ep" in "eu-north-1" has been updated to: privateAccess=false, publicAccess=true

$ ./eksctl  utils update-cluster-endpoints --name=martina-test-priv-ep --private-access=false 
Flag --name has been deprecated, use --cluster
[ℹ]  using region eu-north-1
[ℹ]  current Kubernetes API endpoint access: privateAccess=false, publicAccess=true
[✔]  Kubernetes API endpoint access for cluster "martina-test-priv-ep" in "eu-north-1" is already up to date

@ota42y Sorry for the late reply. I think we can get this merged for version 0.14 :) can you please move the message from the draft file to 0.14.0-draft.md instead? Then if you rebase this will be ready to merge!

[ota42y]

rebased and moved message!

[martina-if]

Thank you @ota42y !