Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement EKS Managed Nodegroups #1566

Merged
merged 51 commits into from
Nov 18, 2019
Merged

Implement EKS Managed Nodegroups #1566

merged 51 commits into from
Nov 18, 2019

Conversation

cPu1
Copy link
Contributor

@cPu1 cPu1 commented Nov 18, 2019

Description

Implements support for EKS Managed Nodegroups

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, and examples directory)
  • Manually tested

cPu1 added 30 commits November 18, 2019 13:34
@cPu1
Add ManagedNodeGroup type
ef151cf
@cPu1
Set defaults for ManagedNodeGroup
21705f5
@cPu1
Attach new policies for EKS, extract out NodeGroup IAM builder to a h…
d32a0b1 
…elper
@cPu1
Use constants for IAM resource names
2a525e3
@cPu1
Use CFN EKS Beta resource
fb808e1
@cPu1
Implement CFN builder for Managed Nodes
0ad13db
@cPu1
Support creating Managed Nodegroups via config file
8c36684
@cPu1
Remove policies no longer needed
9a6532a
@cPu1
Implement creating managed nodegroups via flag --managed
3b13c01
@cPu1
Add configfile tests for Managed Nodes
73fc009
@cPu1
Combine tasks, add tests for ManagedNodeGroup tasks
6c77585
@cPu1
Fix API tests
99fb1cc
@cPu1
Fix printers test
be4bc68
@cPu1
Set AMIType in CFN builder
8cf3914
@cPu1
Validate nodegroup name for uniqueness
66ff0fb
@cPu1
Drain managed nodegroups
ca3a5c2
@cPu1
Combine filter logging for managed and unmanaged nodegroups
0c33e38
@cPu1
Scale managed nodegroups
7cdf1a2
@cPu1
Set description for managed nodegroup stacks
2373862
@cPu1
Attach default cluster security group to nodegroups
5a948f0
@cPu1
Attach a type tag to identify nodegroup type
16b5fc0
@cPu1
Show instanceType for managed nodegroups
10904cf
@cPu1
Fix deleting managed nodegroups
09d7f9c
@cPu1
Extract IAMHelper out into a function
6bc57b7
@cPu1
Ignore shared security group check for managed nodegroups
78ba59c
@cPu1
Add methods for label management and health
37c1543
@cPu1
Add commands for managing labels
93a1912
@cPu1
Add nodegroup health command
740f834
@cPu1
Add support for upgrading managed nodegroups
ca1ba48
@cPu1
Add support for sourceSecurityGroupIds for managed nodes
0c9afea
cPu1 added 21 commits November 18, 2019 13:34
@cPu1
Fix validation for Windows compatibility
a726e55
@cPu1
Fix tests
43aef6f
@cPu1
upgrade: Ignore CFN update if nodegroup is already on the latest release
5b5a272
@cPu1
Fix nodegroup filter for managed nodegroups
51f25c1
@cPu1
upgrade: remove support for --ami-release-version
5aed988
@cPu1
Remove beta resource and beta policies
97fa5e2
@cPu1
Fix scaling, ignore NodeInstanceRoleARN for managed nodegroups
09c6b07
@cPu1
Add Godoc comments
14da32d
@cPu1
ignore CFN update errors for no changes
8e81249
@cPu1
Use commands set and unset for managing labels
89106da
@cPu1
Remove duplicate tests
f6d8be2
@cPu1
Document Managed Nodegroups, add example config
6402c01
@cPu1
Add minor logging and comments
0247552
@cPu1
Update schema doc
8cf3319
@cPu1
Generate mocks
b407fc9
@cPu1
hack: Use local AWS SDK
5b2baa0
@cPu1
Add integration tests for managed nodegroups
db8b34c
@cPu1
Generate deep-copy helpers
6f56567
@cPu1
Fix tests
22c672b
@cPu1
Update usage guide
05679dc
@cPu1
Link to EKS guide
a9191f9
@cPu1
Copy link
Contributor Author

cPu1 commented Nov 18, 2019

Merging this PR per face-to-face review.

@cPu1 cPu1 merged commit d80a1f6 into master Nov 18, 2019
@cPu1 cPu1 deleted the managed-nodes branch November 18, 2019 16:48
@mumoshu mumoshu mentioned this pull request Nov 19, 2019
Closed
@michaelbeaumont michaelbeaumont mentioned this pull request Jan 25, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cPu1 @mumoshu