Readme badges, and CI reports published to Pages - #71
Merged
Merged
Conversation
The two badges there pointed at dotnet.yml and dotnet48.yml, which no longer exist, so they were broken; one build.yml badge replaces both, alongside test-count and line/branch coverage badges. No badge service and no GitHub Pages: the shields URLs are static text, and a job on a green master run rewrites the numbers in place from that run's own results and cobertura, committing only when one changed, with [skip ci] so it starts no new run. Same mechanism as FSharp.Interop.Dlr. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016mwfq4oeZW8SiD4HjTHYdg
An artifact is a zip behind an authenticated download, so it cannot be linked from the readme; Pages can. The site is built from the same artifacts the run already produces - the combined HTML test report and a browsable coverage report - behind a small landing page, deployed from master only. Pages was not configured on this repository and no homepage was set, so the site lands at ekonbenefits.github.io/impromptu-interface. It is public, which is what a public repository's CI output already is. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016mwfq4oeZW8SiD4HjTHYdg
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Workflow concurrency and deployment gating issues remain unresolved.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 2
Open (3)
What changed in this PR
Updates README badges and publishes test and coverage reports to GitHub Pages.
Changes:
- Replaces obsolete badges with current build, test, and coverage badges.
- Adds Pages deployment for test and coverage reports.
- Automates badge updates from CI artifacts.
| File | Summary | Findings |
|---|---|---|
Readme.md |
Adds current CI badges and report links. | None. |
.github/workflows/build.yml |
Generates reports, deploys Pages, and updates badges. | Moderate: Prevent out-of-order Pages deployments and incomplete report publishing. Serialize badge writers and handle push races. Nit: Clarify the badge comment regarding Pages. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+142
to
+143
| needs: [summary, coverage] | ||
| if: github.ref == 'refs/heads/master' && github.event_name != 'pull_request' |
Comment on lines
+143
to
+144
| if: github.ref == 'refs/heads/master' && github.event_name != 'pull_request' | ||
| runs-on: ubuntu-latest |
Comment on lines
+243
to
+244
| # No external badge service and no GitHub Pages: the shields URLs are static text in the | ||
| # README, and this edits them. |
This was referenced Sep 24, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These two commits were on the #70 branch but had not landed when it merged, so they are here instead.
Badges
The two badges in the readme pointed at
dotnet.ymlanddotnet48.yml, deleted in #64 — they were broken, not merely out of date. Onebuild.ymlbadge replaces both, alongside test-count and line/branch coverage.No badge service and no external dependency: the shields URLs are static text, and a
badgesjob on a green master run rewrites the numbers in place from that run's own results JSON and cobertura, committing only when a number changed, with[skip ci]so it starts no new run. The same mechanismFSharp.Interop.Dlruses, so there is one pattern across both.Pages
A CI artifact is a zip behind an authenticated download, so the HTML test report could not be linked from the readme. Pages can, and this repository was not using it — no site configured, no homepage set — so the reports now publish to ekonbenefits.github.io/impromptu-interface:
/tests/— the combined report across net8.0, net10.0, net47 and browser-wasm/coverage/— a browsable line and branch reportBuilt from artifacts the run already produces; the coverage job just emits
Htmlalongside the cobertura it already wrote. Deployed from master only, so the link in the readme always means master rather than whichever branch ran last; PR runs keep the artifact and the run-summary table.Pages is enabled with
build_type: workflow. The site is public, which is what a public repository's CI output already is.ekonbenefits.github.io/impromptu-interfaceis now this project's canonical Pages URL — if docs ever want it, the landing page is the natural place and the reports can move under a path.🤖 Generated with Claude Code
https://claude.ai/code/session_016mwfq4oeZW8SiD4HjTHYdg