Fix crash when copying custom attributes with array constructor arguments

[Methuselah96]

Fixes #56.

As noted by the CustomAttributeTypedArgument docs:

If an argument is an array of values, the Value property of the CustomAttributeTypedArgument that represents the argument returns a generic ReadOnlyCollection of CustomAttributeTypedArgument objects. Each CustomAttributeTypedArgument object in the collection represents the corresponding element of the array.

Therefore, the code that translates the CustomAttributeData to CustomAttributeBuilder needs to convert ReadOnlyCollection constructor arguments to arrays. Example code showing the legitimacy of checking for ReadOnlyCollections is shown in the docs examples:

private static void ShowValueOrArray(CustomAttributeTypedArgument cata)
{
    if (cata.Value.GetType() == typeof(ReadOnlyCollection<CustomAttributeTypedArgument>))
    {
        Console.WriteLine("         Array of '{0}':", cata.ArgumentType);

        foreach (CustomAttributeTypedArgument cataElement in
            (ReadOnlyCollection<CustomAttributeTypedArgument>) cata.Value)
        {
            Console.WriteLine("             Type: '{0}'  Value: '{1}'",
                cataElement.ArgumentType, cataElement.Value);
        }
    }
    else
    {
        Console.WriteLine("         Type: '{0}'  Value: '{1}'",
            cata.ArgumentType, cata.Value);
    }
}

[Methuselah96]

@jbtule Any idea when a new version might be published to NuGet with this fix?

[jbtule]

@Methuselah96 I uploaded it to nuget just now. it's currently validating and indexing.

[Methuselah96]

Thanks!