Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REFACTORING]: deleting the duplicated code #82

Merged
merged 17 commits into from
Jan 22, 2025

Conversation

OlgaYasn
Copy link
Collaborator

@OlgaYasn OlgaYasn commented Jan 9, 2025

Pull Request Template

✨ Title

  • [REFACTORING]: deleting repeated code for VitalityTable and creating VitalityTitle

πŸ“„ Description

Managed to drop the duplication rate from 12.37% to 12,04%

βœ… Checklist

  • I have read and followed the Contribution Guide.
  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings or errors.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • Any dependent changes have been merged and published in downstream modules.

πŸ”— Contextual Links (optional)

Add any relevant links to tracking tickets, previous discussions, or other resources.

πŸ“Έ Visuals (optional)

πŸ” Reviewers

Please assign at least one reviewer for this PR. The PR cannot be merged until it is approved by the reviewer(s).

@OlgaYasn OlgaYasn linked an issue Jan 9, 2025 that may be closed by this pull request
2 tasks
@OlgaYasn OlgaYasn self-assigned this Jan 9, 2025
@OlgaYasn OlgaYasn added the WIP Work in progress label Jan 9, 2025
@OlgaYasn OlgaYasn changed the title Refactor/issue 72/code duplication [REFACTORING]: deleting the duplicated code Jan 9, 2025
@OlgaYasn OlgaYasn force-pushed the refactor/ISSUE-72/code-duplication branch 2 times, most recently from 9383fa0 to 7ca970f Compare January 15, 2025 17:51
@OlgaYasn OlgaYasn force-pushed the refactor/ISSUE-72/code-duplication branch from 7ca970f to f4f93dc Compare January 15, 2025 17:58
@OlgaYasn OlgaYasn added Review is Welcome and removed WIP Work in progress labels Jan 15, 2025
@helabenkhalfallah helabenkhalfallah merged commit 55434e1 into main Jan 22, 2025
1 check passed
@helabenkhalfallah helabenkhalfallah deleted the refactor/ISSUE-72/code-duplication branch January 22, 2025 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[AUDIT]: static code analysis (remove duplications & circular dependencies)
2 participants