Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EVOL]: added lighthouse seo settings #34

Merged
merged 3 commits into from
Nov 21, 2024

Conversation

OlgaYasn
Copy link
Collaborator

@OlgaYasn OlgaYasn commented Nov 18, 2024

Pull Request Template

✨ Title

  • **[EVOL]: added lighthouse seo settings - ISSUE-9

📄 Description

This feature proposes enhancing the LighthouseAuditor to directly incorporate SEO metrics into its existing performance audits. This modification will provide a unified and comprehensive analysis of web pages, encompassing both technical performance and SEO effectiveness within a single report.

✅ Checklist

  • I have read and followed the Contribution Guide.
  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings or errors.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • Any dependent changes have been merged and published in downstream modules.

🔗 Contextual Links (optional)

Add any relevant links to tracking tickets, previous discussions, or other resources.

📸 Visuals (optional)

If possible, include images or videos that show the result of your changes.

🔍 Reviewers

Please assign at least one reviewer for this PR. The PR cannot be merged until it is approved by the reviewer(s).

@OlgaYasn OlgaYasn added the WIP Work in progress label Nov 18, 2024
@OlgaYasn OlgaYasn self-assigned this Nov 18, 2024
@OlgaYasn OlgaYasn changed the title [EVOL]: added lighthouse seo settings - ISSUE-9 [EVOL]: added lighthouse seo settings - #9 Nov 18, 2024
@OlgaYasn OlgaYasn changed the title [EVOL]: added lighthouse seo settings - #9 [EVOL]: added lighthouse seo settings Nov 18, 2024
@OlgaYasn OlgaYasn linked an issue Nov 18, 2024 that may be closed by this pull request
@@ -13,6 +13,7 @@ const VitalityLighthouseReportsCategoryGrouper = dynamic(
);

const VitalityLighthouseReportsDeviceGrouper = ({ reports }: { reports: AuditType[] }) => {
console.log('reports', reports);
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oupsie

@OlgaYasn OlgaYasn added Review is Welcome and removed WIP Work in progress labels Nov 20, 2024
@helabenkhalfallah helabenkhalfallah merged commit 2cffd1b into main Nov 21, 2024
1 check passed
@helabenkhalfallah helabenkhalfallah deleted the evol/ISSUE-9/seo-metrics branch November 21, 2024 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[EVOL]: Enhance LighthouseAuditor to Include SEO Metrics
2 participants