Refactor/architecture code review (#42)

.gitignore

@@ -141,3 +141,4 @@ database/psql/**
 **/v6y-logs/**
 .vscode/
 **/coverage**
+**/.DS_Store

package.json

@@ -28,8 +28,9 @@
   "devDependencies": {
     "husky": "=9.1.4",
     "nx": "=19.3.0",
-    "typescript-coverage-report": "^1.0.0"
+    "typescript-coverage-report": "=1.0.0"
   },
+  "dependencies": {},
   "workspaces": [
     "src/**"
   ]

src/v6y-bff/src/index.ts

@@ -1,6 +1,6 @@
 import { ApolloServer } from '@apollo/server';
 import { ApolloServerPluginDrainHttpServer } from '@apollo/server/plugin/drainHttpServer';
-import { AppLogger, DataBaseManager, ServerUtils, passportInitialize } from '@v6y/commons';
+import { AppLogger, DataBaseManager, ServerUtils, configureAuthMiddleware } from '@v6y/commons';
 import Express from 'express';
 import ExpressStatusMonitor from 'express-status-monitor';
 
@@ -35,7 +35,7 @@ app.use(
 
 // *********************************************** Graphql Config & Endpoints ***********************************************
 
-app.use(passportInitialize());
+app.use(configureAuthMiddleware());
 
 const httpServer = createServer({
     app,

src/v6y-bff/src/resolvers/account/AccountQueries.ts

@@ -5,7 +5,7 @@ import {
     AppLogger,
     PasswordUtils,
     SearchQueryType,
-    passportGenerateToken,
+    generateAuthenticationToken,
 } from '@v6y/commons';
 
 const { validatePassword } = PasswordUtils;
@@ -76,7 +76,7 @@ const getAccountListByPageAndParams = async (_: unknown, args: SearchQueryType)
 /**
  * Login account
  * @param _
- * @param paramsc
+ * @param params
  */
 const loginAccount = async (_: unknown, params: { input: AccountLoginType }) => {
     try {
@@ -103,7 +103,7 @@ const loginAccount = async (_: unknown, params: { input: AccountLoginType }) =>
             return null;
         }
 
-        const token = passportGenerateToken(accountDetails);
+        const token = generateAuthenticationToken(accountDetails);
 
         AppLogger.info(`[AccountMutations - loginAccount] login success : ${accountDetails._id}`);
 

src/v6y-bff/src/resolvers/manager/AuthenticationManager.ts

@@ -1,6 +1,6 @@
 import { ApolloServer } from '@apollo/server';
 import { expressMiddleware } from '@apollo/server/express4';
-import { passportAuthenticate } from '@v6y/commons';
+import { validateCredentials } from '@v6y/commons';
 import BodyParser from 'body-parser';
 import Cors from 'cors';
 import { RequestHandler } from 'express';
@@ -19,7 +19,7 @@ export function buildUserMiddleware(
                     req.body?.operationName !== 'LoginAccount' &&
                     req.body?.operationName !== 'IntrospectionQuery'
                 ) {
-                    const user = await passportAuthenticate(req);
+                    const user = await validateCredentials(req);
                     if (!user) {
                         throw new Error('Unauthorized');
                     }