Updated to 0.1.5 (to the main branch) #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
<!-- For Work In Progress Pull Requests, please use the Draft PR feature, see https://github.blog/2019-02-14-introducing-draft-pull-requests/ for further details. For a timely review/response, please avoid force-pushing additional commits if your PR already received reviews or comments. Before submitting a Pull Request, please ensure you've done the following: - 📖 Read the our Code of Conduct: https://github.com/ekinkaradag/snake-vue3/blob/main/CODE_OF_CONDUCT.md - 👷♀️ Create small PRs. In most cases this will be possible. - ✅ Provide tests for your changes (Not applicable yet. Disregard). - 📝 Use descriptive commit messages. - 📗 Update any related documentation and include any relevant screenshots. --> ## What type of PR is this? (check all applicable) - [X] 💻 Refactor - [ ] 🍕 Feature - [ ] 🐛 Bug Fix - [ ] 🚀 Optimization - [ ] 📃 Documentation Update ## Description ## Related Tickets & Documents <!-- For pull requests that relate or close an issue, please include them below. We like to follow [Github's guidance on linking issues to pull requests](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue). For example having the text: "closes #1234" would connect the current pull request to issue 1234. And when we merge the pull request, Github will automatically close the issue. --> - Related Issue #22 - Closes #22 ## QA Instructions, Screenshots, Recordings _None_ ### UI accessibility checklist _If your PR includes UI changes, please utilize this checklist:_ - [X] Semantic HTML implemented? - [X] Keyboard operability supported? - [X] Color contrast tested? ## [disregard] Added/updated tests? (Not applicable yet) - [ ] 👍 Yes - [ ] 👎 No, and this is why: _please replace this line with details on why tests have not been included_ - [ ] ✋ I need help with writing tests ## [optional] Are there any post deployment tasks we need to perform? ## [optional] What gif best describes this PR or how it makes you feel? 
<!-- For Work In Progress Pull Requests, please use the Draft PR feature, see https://github.blog/2019-02-14-introducing-draft-pull-requests/ for further details. For a timely review/response, please avoid force-pushing additional commits if your PR already received reviews or comments. Before submitting a Pull Request, please ensure you've done the following: - 📖 Read the our Code of Conduct: https://github.com/ekinkaradag/snake-vue3/blob/main/.github/CODE_OF_CONDUCT.md - 👷♀️ Create small PRs. In most cases this will be possible. - ✅ Provide tests for your changes (Not applicable yet. Disregard). - 📝 Use descriptive commit messages. - 📗 Update any related documentation and include any relevant screenshots. --> ## What type of PR is this? (check all applicable) - [ ] 💻 Refactor - [ ] 🍕 Feature - [X] 🐛 Bug Fix - [ ] 🚀 Optimization - [ ] 📃 Documentation Update ## Description ## Related Tickets & Documents <!-- For pull requests that relate or close an issue, please include them below. We like to follow [Github's guidance on linking issues to pull requests](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue). For example having the text: "closes #1234" would connect the current pull request to issue 1234. And when we merge the pull request, Github will automatically close the issue. --> - Related Issue #25 - Closes #25 ## QA Instructions, Screenshots, Recordings _Please replace this line with instructions on how to test your changes, a note on the devices and browsers this has been tested on, as well as any relevant images for UI changes._ ### UI accessibility checklist _If your PR includes UI changes, please utilize this checklist:_ - [X] Semantic HTML implemented? - [X] Keyboard operability supported? - [X] Color contrast tested? ## [disregard] Added/updated tests? (Not applicable yet) - [ ] 👍 Yes - [ ] 👎 No, and this is why: _please replace this line with details on why tests have not been included_ - [ ] ✋ I need help with writing tests ## [optional] Are there any post deployment tasks we need to perform? <em>No</em> ## [optional] What gif best describes this PR or how it makes you feel? 
<!-- For Work In Progress Pull Requests, please use the Draft PR feature, see https://github.blog/2019-02-14-introducing-draft-pull-requests/ for further details. For a timely review/response, please avoid force-pushing additional commits if your PR already received reviews or comments. Before submitting a Pull Request, please ensure you've done the following: - 📖 Read the our Code of Conduct: https://github.com/ekinkaradag/snake-vue3/blob/main/.github/CODE_OF_CONDUCT.md - 👷♀️ Create small PRs. In most cases this will be possible. - ✅ Provide tests for your changes (Not applicable yet. Disregard). - 📝 Use descriptive commit messages. - 📗 Update any related documentation and include any relevant screenshots. --> ## What type of PR is this? (check all applicable) - [ ] 💻 Refactor - [X] 🍕 Feature - [ ] 🐛 Bug Fix - [X] 🚀 Optimization - [ ] 📃 Documentation Update ## Description ## Related Tickets & Documents <!-- For pull requests that relate or close an issue, please include them below. We like to follow [Github's guidance on linking issues to pull requests](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue). For example having the text: "closes #1234" would connect the current pull request to issue 1234. And when we merge the pull request, Github will automatically close the issue. --> - Related Issue #14 - Closes #14 ## QA Instructions, Screenshots, Recordings Now the grid is always displayed even with a fresh page. This was done to give more of a "consistent" feeling to the user. ### UI accessibility checklist _If your PR includes UI changes, please utilize this checklist:_ - [X] Semantic HTML implemented? - [X] Keyboard operability supported? - [X] Color contrast tested? ## [disregard] Added/updated tests? (Not applicable yet) - [ ] 👍 Yes - [ ] 👎 No, and this is why: _please replace this line with details on why tests have not been included_ - [ ] ✋ I need help with writing tests ## [optional] Are there any post deployment tasks we need to perform? ## [optional] What gif best describes this PR or how it makes you feel? 
<!-- For Work In Progress Pull Requests, please use the Draft PR feature, see https://github.blog/2019-02-14-introducing-draft-pull-requests/ for further details. For a timely review/response, please avoid force-pushing additional commits if your PR already received reviews or comments. Before submitting a Pull Request, please ensure you've done the following: - 📖 Read the our Code of Conduct: https://github.com/ekinkaradag/snake-vue3/blob/main/.github/CODE_OF_CONDUCT.md - 👷♀️ Create small PRs. In most cases this will be possible. - ✅ Provide tests for your changes (Not applicable yet. Disregard). - 📝 Use descriptive commit messages. - 📗 Update any related documentation and include any relevant screenshots. --> ## What type of PR is this? (check all applicable) - [X] 💻 Refactor - [X] 🍕 Feature - [X] 🐛 Bug Fix - [ ] 🚀 Optimization - [ ] 📃 Documentation Update ## Description ## Related Tickets & Documents <!-- For pull requests that relate or close an issue, please include them below. We like to follow [Github's guidance on linking issues to pull requests](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue). For example having the text: "closes #1234" would connect the current pull request to issue 1234. And when we merge the pull request, Github will automatically close the issue. --> ## QA Instructions, Screenshots, Recordings _Please replace this line with instructions on how to test your changes, a note on the devices and browsers this has been tested on, as well as any relevant images for UI changes._ ### UI accessibility checklist _If your PR includes UI changes, please utilize this checklist:_ - [X] Semantic HTML implemented? - [X] Keyboard operability supported? - [X] Color contrast tested? ## [disregard] Added/updated tests? (Not applicable yet) - [ ] 👍 Yes - [ ] 👎 No, and this is why: _please replace this line with details on why tests have not been included_ - [ ] ✋ I need help with writing tests ## [optional] Are there any post deployment tasks we need to perform? ## [optional] What gif best describes this PR or how it makes you feel?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
Related Tickets & Documents
QA Instructions, Screenshots, Recordings
Please replace this line with instructions on how to test your changes, a note
on the devices and browsers this has been tested on, as well as any relevant
images for UI changes.
UI accessibility checklist
If your PR includes UI changes, please utilize this checklist:
[disregard] Added/updated tests? (Not applicable yet)
have not been included
[optional] Are there any post deployment tasks we need to perform?
[optional] What gif best describes this PR or how it makes you feel?