update your branch to include all the work that I did in this one #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The variables used to be called wp_namespace_* which was confusing because the software is not only useful for Wikipedia and is not only useful for matching namespaces.
All the code to check for patterns within diff are named regex, regexes, etc. This is problematic because (a) we already have one more place we can check for regex and (b) I'm about to about add code to look for regex in abitrary revisions (/not/ diffs). This change "makes room" for the next one.
It's already a single field.
It's really just nothing something most people will use it and it's somewhat expensive to compute.
$ make g++ -O3 -c -o wikiq.o wikiq.cpp wikiq.cpp: In function ‘void print_usage(char**)’: wikiq.cpp:549:10: error: expected primary-expression before ‘<<’ token make: *** [wikiq.o] Error 1
- specified that the Ubuntu packages are also Debian packages
- new README.md points to the new version of the software - old README moved to README.old
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Greetings @ekg!
I think it would be useful if you update your version of
wikiqso that it is up-to-date with mine. This includes pulling in a bunch of changes I (and others) made to make wikiq work more effectively in ~2014.Most importantly though, it includes a new README.md file that explain that this C++ codebase is no longer maintained and there is a new codebase that is maintained.
I've had trouble with students going off to use 'wikiq' and finding your version instead of the modern piece of software and they lost a day or two into it. In that sense, it would be helpful if your version also included a README.md file explaining the current situation.
Thanks!