Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed an issue in which the file path containing spaces could not be grepped #136

Merged
merged 9 commits into from
Dec 25, 2022

Conversation

ZeroOnePro
Copy link
Contributor

When running a script on path "/home/foo bar/test.md", there was a problem that the file path was not grep properly like this

grep ./home/foo/: No such file or directory
grep bar: No such file or directory
grep name: No such file or directory
grep test.md No such file or directory

So I solved the problem by adding a comma to $gh_src

@ekalinin
Copy link
Owner

Thanks for the fix!
Could you, please, add some test for this case.

@ZeroOnePro
Copy link
Contributor Author

ZeroOnePro commented Jul 17, 2022

I forgot about the test. added it please check
thanks a lot

@ZeroOnePro
Copy link
Contributor Author

There was a problem when using it with the insert flag, but the test did not reflect it, so I modified it

@ekalinin ekalinin merged commit 661b5c5 into ekalinin:master Dec 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants