Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated Bottle.py and Bottle_server.py #46

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Updated Bottle.py and Bottle_server.py #46

wants to merge 4 commits into from

Conversation

jainishmehta
Copy link

@jainishmehta jainishmehta commented Mar 1, 2021 •
edited
Loading

Updates include:

  1. Update for bottle.py from python2 to python3 (if this is not needed, I can do another pull request).
  2. Bottle_server.py is updated to take out the "/checker-framework-3.9.1" as it is machine-dependent, a comment is added for future reference.
  3. Run-checker script is changed back to -Xmx2500M for memory

@wmdietl wmdietl mentioned this pull request Mar 10, 2021
Closed
wmdietl
wmdietl reviewed Mar 10, 2021
View reviewed changes
Copy link
Member

@wmdietl wmdietl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates!

bottle_server.py Show resolved Hide resolved
bottle_server.py
@@ -36,14 +36,14 @@
app = Bottle()
default_app.push(app)

import StringIO # NB: don't use cStringIO since it doesn't support unicode!!!
import io # NB: don't use cStringIO since it doesn't support unicode!!!
import json
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the README, explain how to update bottle.py and that no local modifications of that file should be done.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure I completely understand, but I updated the README.md, please let me know if there is something more you want me to add.

bottle_server.py Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wmdietl wmdietl wmdietl left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jainishmehta @wmdietl