Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed indent errors #5

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fixed indent errors #5

wants to merge 1 commit into from

Conversation

nawazbaba1993
Copy link

No description provided.

@locmai
Copy link

locmai commented Dec 31, 2021

Having the same issue and this seems like a legit PR actually

@locmai
Copy link

locmai commented Dec 31, 2021

Also had this one from deployment-web.yaml

error validating data: ValidationError(Deployment.spec.template.metadata): unknown field "checksum/config-settings" in io.k8s.apimachinery.pkg.apis.meta.v1.ObjectMeta

Due to this line:

saleor-k8s/charts/saleor-core/templates/deployment-web.yaml

Line 23 in befcbbb

checksum/config-settings: {{ include (print $.Template.BasePath "/configmap-settings.yaml") . | sha256sum }}

@FelipeSanchezCalzada
Copy link

I am also experiencing various problems with the master branch code. Among them this one that is solved here, but even so I have many more problems. I wonder if the project has been abandoned.

@Tjerk-Haaye-Henricus
Copy link

I wonder if this one will be merged one day :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ohenenyame ohenenyame ohenenyame approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@nawazbaba1993 @locmai @FelipeSanchezCalzada @Tjerk-Haaye-Henricus @ohenenyame @nawaz-b