Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

custom field Views plugin, test not using createEntity #494

Open
wants to merge 4 commits into
base: 4.0.x
Choose a base branch
from

Conversation

jackrabbithanna
Copy link
Collaborator

@jackrabbithanna jackrabbithanna commented Jul 25, 2024

Overview

I saw a request for some performance optimization of Views with a large dataset
https://civicrm.stackexchange.com/questions/48376/drupal-views-using-civicrm-entity-with-relationships-added-takes-too-long-to-ren

Was provided an XHProf profile, and we discovered an inordinate amount of time spent cloning entities.

Optimize CustomEntityField plugin.

We know that cloning the entity takes ALOT of time.
I also wonder if we can get rid of the API call to CustomValue

Before

Molasses is faster

After

Competitive speed vs. Molasses.

@civibot civibot bot added the 4.0.x label Jul 25, 2024
@jackrabbithanna
Copy link
Collaborator Author

Test passes commenting out createEntity() are not a sign all is well.
For sure YesNo field type needs help. If add a custom field of that type to the View, then if there is no value, still "No" is rendered.
Same for the datetime conversion done in that plugin.

There maybe other reasons why that method / entity processing needs be done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant