custom field Views plugin, test not using createEntity #494
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
I saw a request for some performance optimization of Views with a large dataset
https://civicrm.stackexchange.com/questions/48376/drupal-views-using-civicrm-entity-with-relationships-added-takes-too-long-to-ren
Was provided an XHProf profile, and we discovered an inordinate amount of time spent cloning entities.
Optimize CustomEntityField plugin.
We know that cloning the entity takes ALOT of time.
I also wonder if we can get rid of the API call to CustomValue
Before
Molasses is faster
After
Competitive speed vs. Molasses.