Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

moving Rules integration to a submodule #462

Open
wants to merge 1 commit into
base: 4.0.x
Choose a base branch
from

Conversation

jackrabbithanna
Copy link
Collaborator

Overview

Move Rules integration, including TypeData filters, Rules Actions, and Rules conditions to a submodule.

Technical Details

Reports of errors by users with CE installed and Rules not installed.

Release notes snippet

Change record should inform users to install CiviCRM Entity Rules module if using any of the provided conditions/actions

@civibot civibot bot added the 4.0.x label Jan 23, 2024
@jackrabbithanna
Copy link
Collaborator Author

This PR was made to provide a patch for somebody that made a support request: https://www.drupal.org/project/civicrm_entity/issues/3416406
We've never experienced the reported error, and definitely have sites without the Rules module. Perhaps there is some condition for this user to experience it.
CE could be made to require Rules, but we think it preferable for Rules to be optional.

This change would mean people would need to install a submodule, civicrm_entity_rules IF they use any Rules conditions/actions provided by CiviCRM Entity .. they would have to read the release notes, and know to do it.

Also considering doing something like we did for the VBO action https://github.com/eileenmcnaughton/civicrm_entity/blob/4.0.x/src/Plugin/Action/CivicrmContactAddToGroup.php#L14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant