Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix column name for grouping custom fields in Views #442

Open
wants to merge 2 commits into
base: 4.0.x
Choose a base branch
from

Conversation

mglaman
Copy link
Contributor

@mglaman mglaman commented Aug 18, 2023

Overview

Fixes the column Views uses for grouping custom fields. It was defaulting to value, the default column name for fields.

Technical Details

Provides a wrapped base field definition class to always return proper column names for custom fields. Modifies a View plugin method which replaces the field definition class.

Comments

Anything else you would like the reviewer to note

Release notes snippet

The notes to be added on the release

@mglaman
Copy link
Contributor Author

mglaman commented Aug 18, 2023

Okay looks like legitimate errors after I fixed my typos. Will look at it today

@jackrabbithanna
Copy link
Collaborator

I had left this PR in one of my locals.

I observed that with this PR, adding a Civi custom field, that is in a Civi custom field group allowing multiple values, breaks the View.

I see errors like:
The view test_multi_civi_fields_view failed to load an entity of type civicrm_contact at row 1 for field multi_1_20

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants