fix Views field custom date field output for year only #439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Difference between this and contributed PR for 3.x branch is to always use date_default_timezone_get() and not the system-wide timezone configuration value |
jackrabbithanna
commented
Oct 19, 2023
| */ | ||
| public function convertToUtc(FieldDefinitionInterface $definition, $date_value) { | ||
| $datetime_format = $definition->getSetting('datetime_type') === DateTimeItem::DATETIME_TYPE_DATE ? DateTimeItemInterface::DATE_STORAGE_FORMAT : DateTimeItemInterface::DATETIME_STORAGE_FORMAT; | ||
| $default_timezone = date_default_timezone_get(); |
There was a problem hiding this comment.
This line is the difference from PR #435 for the 3.x branch
There was a problem hiding this comment.
If using the global configuration then if the per-user timezone setting is allowed, and if the user chooses a different timezone, then could have a discrepancy. Drupal manages this and gives the "right" timezone returned by date_default_timezone_get();
|
We've applied this PR on production and can confirm this is working for year-only custom fields. |
jitendrapurohit
approved these changes
Feb 15, 2024
puresyntax71
added a commit
to puresyntax71/civicrm_entity
that referenced
this pull request
Apr 19, 2024
* origin/4.0.x: 4.0.x field mappings (eileenmcnaughton#430) Adding a raw value function to return value from values array (eileenmcnaughton#465) Add filter for state province. (eileenmcnaughton#453) Update default timezone handling for dates in CiviEntityStorage.php (eileenmcnaughton#461) fix testLoadContact birthdate assertion (eileenmcnaughton#472) port to 4.0.x from 436: Include dblocale table names in list of civicrm entity info (eileenmcnaughton#438) Ignore convert to UTC if custom field is date only (eileenmcnaughton#469) update contact entity referece field on contact merge (eileenmcnaughton#456) update test versions of Drupal 10.2 and CiviCRM 5.69 (eileenmcnaughton#468) Clean value on custom field for Float (Number) and Money field type (eileenmcnaughton#463) From eileenmcnaughton#378 for 4.0.x (eileenmcnaughton#466) Add reset to the file URLs generated. (eileenmcnaughton#458) fix Views field custom date field output for year only (eileenmcnaughton#439)
puresyntax71
added a commit
to puresyntax71/civicrm_entity
that referenced
this pull request
Apr 27, 2024
* origin/4.0.x: (41 commits) patch from issue 3420771 (eileenmcnaughton#475) only check for data in enabled components on module uninstall (eileenmcnaughton#476) Adds is Empty/NULL operators (eileenmcnaughton#423) Pathauto (eileenmcnaughton#470) fix test to use string instead of integer for zip code (eileenmcnaughton#474) 4.0.x field mappings (eileenmcnaughton#430) Adding a raw value function to return value from values array (eileenmcnaughton#465) Add filter for state province. (eileenmcnaughton#453) Update default timezone handling for dates in CiviEntityStorage.php (eileenmcnaughton#461) fix testLoadContact birthdate assertion (eileenmcnaughton#472) port to 4.0.x from 436: Include dblocale table names in list of civicrm entity info (eileenmcnaughton#438) Ignore convert to UTC if custom field is date only (eileenmcnaughton#469) update contact entity referece field on contact merge (eileenmcnaughton#456) update test versions of Drupal 10.2 and CiviCRM 5.69 (eileenmcnaughton#468) Clean value on custom field for Float (Number) and Money field type (eileenmcnaughton#463) From eileenmcnaughton#378 for 4.0.x (eileenmcnaughton#466) Add reset to the file URLs generated. (eileenmcnaughton#458) fix Views field custom date field output for year only (eileenmcnaughton#439) update Add Contact to Group Views Bulk operations action plugin access handler (eileenmcnaughton#464) Readme update (eileenmcnaughton#457) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port and tweak of contributed PR #435
Before
Year only custom date fields for some time zones displays wrong value.
After
Custom fields with year only format always show correctly.