Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add error logging in case the tar extraction fails #418

Closed
wkillerud opened this issue Jul 2, 2024 · 1 comment · Fixed by #420
Closed

Add error logging in case the tar extraction fails #418

wkillerud opened this issue Jul 2, 2024 · 1 comment · Fixed by #420
Assignees
@wkillerud
Labels
enhancement New feature or request released

Comments

@wkillerud
Copy link
Contributor

From eik-lib/sink-gcs#263

We are also a bit in the blind here; we seems to be missing logs if extracting the file errors: https://github.com/eik-lib/core/blob/master/lib/multipart/parser.js#L134-L150 We should a bit of error logging here.
@wkillerud wkillerud added the enhancement New feature or request label Jul 2, 2024
@wkillerud wkillerud mentioned this issue Jul 2, 2024
Merged
@wkillerud wkillerud self-assigned this Jul 2, 2024
wkillerud added a commit that referenced this issue Jul 2, 2024
@wkillerud
fix: add some logging in case archive parsing fails
02abf2b 
We've seen some errors for archives with a large number of files,
but without logging we're guessing a bit more than we'd like.

Fixes #418
@wkillerud wkillerud mentioned this issue Jul 2, 2024
Merged
github-actions bot pushed a commit that referenced this issue Jul 3, 2024
@semantic-release-bot
chore(release): 1.3.46 [skip ci]
b0882b7 
## [1.3.46](v1.3.45...v1.3.46) (2024-07-03)

### Bug Fixes

* add some logging in case archive parsing fails ([#420](#420)) ([d4f1a88](d4f1a88)), closes [#418](#418)
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 3, 2024

🎉 This issue has been resolved in version 1.3.46 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wkillerud wkillerud

Labels
enhancement New feature or request released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: add some logging in case archive parsing fails eik-lib/core
1 participant
@wkillerud