fix: Update dependencies (#370)

* fix: Update dependencies * ci: lint love --------- Co-authored-by: Trygve Lie <[email protected]>
eik-lib · Jun 2, 2023 · 0c671f4 · 0c671f4
1 parent e3e1a49
commit 0c671f4
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 13 deletions.
diff --git a/.github/workflows/publish.yml b/.github/workflows/publish.yml
@@ -14,7 +14,7 @@ jobs:
   - name: Setup Node.js
     uses: actions/setup-node@v3
     with:
-      node-version: 16.x
+      node-version: 18.x
   - name: npm install
     run: |
       npm install
@@ -35,7 +35,7 @@ jobs:
   - name: Setup Node.js
     uses: actions/setup-node@v3
     with:
-      node-version: 16.x
+      node-version: 18.x
   - name: npm install
     run: |
       npm install

diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
@@ -8,7 +8,7 @@ jobs:
     strategy:
       matrix:
         os: [ubuntu-latest, macOS-latest, windows-latest]
-        node-version: [14.x, 16.x]
+        node-version: [14.x, 16.x, 18.x, 20.x]
     steps:
       - uses: actions/checkout@v3
       - name: Use Node.js ${{ matrix.node-version }}

diff --git a/lib/sinks/fs.js b/lib/sinks/fs.js
@@ -1,6 +1,6 @@
 import { ReadFile } from '@eik/common';
+import { rimraf } from 'rimraf';
 import Metrics from '@metrics/client';
-import rimraf from 'rimraf';
 import Sink from '@eik/sink';
 import mime from 'mime';
 import path from 'node:path';
@@ -204,18 +204,17 @@ const SinkFS = class SinkFS extends Sink {
                 return;
             }
 
-            rimraf(pathname, error => {
-                if (error) {
-                    this._counter.inc({ labels: { access: true, operation } });
-                    reject(error);
-                    return;
-                }
+            rimraf(pathname).then(() => {
                 this._counter.inc({ labels: { 
                     success: true, 
                     access: true, 
                     operation 
                 } });
                 resolve();
+            }).catch((error) => {
+                this._counter.inc({ labels: { access: true, operation } });
+                reject(error);
+
             });
         });
     }

diff --git a/package.json b/package.json
@@ -27,7 +27,7 @@
     "http-errors": "2.0.0",
     "mime": "3.0.0",
     "original-url": "1.2.3",
-    "rimraf": "3.0.2",
+    "rimraf": "5.0.1",
     "semver": "7.5.1",
     "ssri": "10.0.4",
     "tar": "6.1.15",
@@ -43,10 +43,10 @@
     "eslint-plugin-import": "2.27.5",
     "eslint-plugin-prettier": "4.2.1",
     "form-data": "4.0.0",
-    "mkdirp": "1.0.4",
+    "mkdirp": "3.0.1",
     "node-fetch": "3.3.1",
     "prettier": "2.8.8",
-    "semantic-release": "19.0.5",
+    "semantic-release": "21.0.2",
     "tap": "16.3.4"
   }
 }