-
Notifications
You must be signed in to change notification settings - Fork 61
Improve documentation #305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 2 commits
48ac5fc
867cfb7
2493ec2
6d5312c
fed5cb3
6fe1af3
5de3f4b
31d1ec0
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -1,5 +1,5 @@ | ||||||
| <!--- | ||||||
| Copyright 2017 Ericsson AB. | ||||||
| Copyright 2017-2022 Ericsson AB. | ||||||
| For a full list of individual contributors, please see the commit history. | ||||||
|
|
||||||
| Licensed under the Apache License, Version 2.0 (the "License"); | ||||||
|
|
@@ -34,3 +34,30 @@ The design of Eiffel events is governed by the following guidelines: | |||||
| * __Key names in camelCase:__ All key names shall use camelCase. | ||||||
| * __Enumerations in CAPS_WITH_UNDERSCORE:__ All enumerated values shall use CAPS_WITH_UNDERSCORE. | ||||||
| * __Link types are nouns:__ Link types shall have names that fit the pattern "\<target event> is the \<source event>'s \<link type>", implying that they are nouns that describe the relationship between the source and the target event. | ||||||
|
|
||||||
| ## Benefits and Implications | ||||||
|
|
||||||
| By following the design guidelines the Eiffel protocol provides a language that | ||||||
| gives producer and consumer a common way of understanding and describing the | ||||||
|
||||||
| gives producer and consumer a common way of understanding and describing the | |
| gives producers and consumers a common way of understanding and describing the |
There are other similar cases, I won't make suggestions for all of them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I hope I got them in 6d5312c
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| Following the guidlines stated, they adress the following issues: | |
| Following the guidelines stated, they address the following issues: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in 6d5312c
m-linner-ericsson marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
magnusbaeck marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This sentence doesn't read too well (two subclauses beginning with "by XXXing"). Something like this?
The Eiffel protocol minimizes coordination effort between producers and consumers by defining a specification that the parties can use as a contract.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, reworded it based on you suggestion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Better, but there are a couple of remaining nits. Suggestion:
The Eiffel protocol minimizes coordination efforts between producers and consumers by providing a well-defined specification that the parties can use as a contract.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in 5de3f4b ( and do hope I got it this time)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be about not adding data that needs specific contextual knowledge? Or should it be about aggregation?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here I was thinking about aggregation. Do you have any good ideas for improvement?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Do you aggregate data on the producer side and add that data as custom data? If the producer aggregates the data it will do so for a specific consumer but we want to create a protocol that can serve any consumer for use cases that has not yet seen the light. Therefore try to use the existing fields and aggregate data on the consumer side."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in 6d5312c