ED: Complement data.image with RUNTIME_ENVIRONMENT link type #264
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sounds reasonable. Need some more time to digest the idea though, and to review the PR. |
t-persson
previously approved these changes
Aug 10, 2021
There was a problem hiding this comment.
I approve this from my side, but we still have to wait for @e-backmark-ericsson and co to digest and approve this (i.e. do not merge :) )
The data.image member of EiffelEnvironmentDefinedEvent is ambiguous and doesn't keep the Eiffel DAG together even though the entities described in its values can certainly be described with Eiffel events. Discourage from use of that member and add a new RUNTIME_ENVIRONMENT link type that can link to ArtC or CD. The target events can e.g. describe Docker or VM images, JVM distribution archives, or compositions of operating system packages installed on the host.
magnusbaeck
force-pushed
the
runtime-env
branch
from
b91477d to
de1f6dc
Compare
magnusbaeck
changed the title
|
@t-persson @e-backmark-ericsson @m-linner-ericsson |
|
This is okay for me. |
m-linner-ericsson
approved these changes
Sep 10, 2021
There was a problem hiding this comment.
Sounds like what we talked about in the TC meeting. @e-backmark-ericsson: Do you agree?
t-persson
approved these changes
Sep 16, 2021
e-backmark-ericsson
approved these changes
Sep 16, 2021
e-backmark-ericsson
pushed a commit
to e-backmark-ericsson/eiffel
that referenced
this pull request
Apr 13, 2022
…community#264) The data.image member of EiffelEnvironmentDefinedEvent is ambiguous and doesn't keep the Eiffel DAG together even though the entities described in its values can certainly be described with Eiffel events. Discourage from use of that member and add a new RUNTIME_ENVIRONMENT link type that can link to ArtC or CD. The target events can e.g. describe Docker or VM images, JVM distribution archives, or compositions of operating system packages installed on the host.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applicable Issues
Fixes #258
Description of the Change
The
data.imagemember of EiffelEnvironmentDefinedEvent is ambiguous and doesn't keep the Eiffel DAG together even though the entities described in its values can certainly be described with Eiffel events. Mark the member as discouraged and add a new RUNTIME_ENVIRONMENT link type that can link to ArtC or CD. The target events can e.g. describe Docker or VM images, JVM distribution archives, or compositions of operating system packages installed on the host.Alternate Designs
The issue suggests the link type name IMAGE, but that's too specific and isn't a good fit for compositions of packages. I'm not terribly happy with RUNTIME_ENVIRONMENT either but it's the best I came up with.
Benefits
Environments can use the Eiffel DAG. This makes the environment definition less ambiguous and more expressive.
Possible Drawbacks
None.
Sign-off
Developer's Certificate of Origin 1.1
By making a contribution to this project, I certify that:
(a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or
(b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or
(c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it.
(d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved.
Signed-off-by: Magnus Bäck <[email protected]>