Skip to content

Conversation

@d-stahl-ericsson
Copy link
Contributor

Applicable Issues

#191

Description of the Change

Updated versioning.md and the version history of each event type in preparation of edition-agen. Once merged, the resulting commit will immediately be tagged.

Alternate Designs

N/A

Benefits

N/A

Possible Drawbacks

N/A

Sign-off

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or

(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or

(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.

(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.

Signed-off-by: Daniel Ståhl [email protected]

Copy link
Contributor

@l-ohlen-ericsson l-ohlen-ericsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. One day I would like to know the secret logic behind the selection of the city names...

@d-stahl-ericsson
Copy link
Contributor Author

Isn't it obvious? :)

Copy link
Member

@e-backmark-ericsson e-backmark-ericsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good apart from a small typo

| Lyon | _Reserved for future use._ | |
| Paris | _Reserved for future use._ | |
| Agen | _Reserved for future use._ | |
| Agen | [edition-agen](../../../tree/edition-agen) | Introduced [EiffelIssueDefinedEvent](../eiffel-vocabulary/EiffelIssueDefinedEvent.md). Updated meta.security of all event types. Changed from GAV to purl based artifact identification. Introduced automated packaging of schema files for edition tags. Added detailed rules and exmaples for event type version stepping. |

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo: exmaples

@d-stahl-ericsson
Copy link
Contributor Author

Thanks! Fixed.

Copy link
Member

@e-backmark-ericsson e-backmark-ericsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@d-stahl-ericsson d-stahl-ericsson merged commit bcac2c7 into eiffel-community:master Sep 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants