Added EiffelSourceChangeCreatedEvent documentation. #15
Conversation
| __Required:__ Yes | ||
| __Description:__ The branch of the change. | ||
|
|
||
| #### data.ccCompositeIdentifier.configSpecPath |
There was a problem hiding this comment.
Shouldn't we use a URI for the configSpecPath?
There was a problem hiding this comment.
I think we should.
| __Required:__ Yes | ||
| __Description:__ The URI of the repo. | ||
|
|
||
| ### data.gerritIdentifier |
There was a problem hiding this comment.
What is the reason behind the separate data structure behind Gerrit? Should we then have GitHub, BitBucket, GitLab, GoGS and so on? There is no big problem to describe gerrit changes using fields defined for the Git data structure
There was a problem hiding this comment.
It's a balance, I guess. As you say, you could go conservative and treat it as any other Git repo, or you could make allowances for particular information (e.g. patch set, Change-Id) where convenient. As a rule I favor conservatism, so I think you have a point.
…onsistency. Specified that this should be a URI.
d-stahl-ericsson
force-pushed
the
topic-drop2-sourcechangecreated
branch
from
5fa7226 to
5238351
Compare
|
I removed the Gerrit identifier and added details, tracker and id as optional fields to data.change instead. This should afford a more generic approach: the basic identifier is the same, but if you're using supporting tools you can reference them there in addition to the identifier. I'm bouncing the ClearCase identifier off of some people to get their feedback. |
|
👍 |
|
👍 This event type, like the EnvironmentDefined event could end up being a very flexible event representing real life more than other more CI-ish events. I propose we live with what we have and modify as needed. |
* Add SECURITY.md file Adding the SECURITY.md file from the community repository to this one.
4 participants
No description provided.