Skip to content

Conversation

@d-stahl-ericsson
Copy link
Contributor

As per issue #130. Notice was not added to .json and .gliffy files (which are also JSON files) as comments are not supported. Arguably that is less of a concern: the important thing is that documentation and code contains the license notice.

@d-stahl-ericsson
Copy link
Contributor Author

Any feedback on this? Unless there are objections I will merge this tomorrow.

@e-backmark-ericsson
Copy link
Member

Since there is a copyright mail thread running right now I'd propose that we postpone the merge of this PR until we see a consensus there.
Anyone interested to see that mail thread can contact me.

@l-ohlen-ericsson
Copy link
Contributor

The copyright headers is designed as discussed in the mail thread, so lets go for this.
For sure the same headers needs to be applied to other parts (java code) as well...

@d-stahl-ericsson
Copy link
Contributor Author

@l-ohlen-ericsson in other repos (e.g. Eiffel implementations) you mean? Because there's no Java code in this repo. But yes, the same scheme should be applied to other repos as well.

@l-ohlen-ericsson
Copy link
Contributor

Yes, I meant other Eiffel components and repos.

@xvinosi-github
Copy link
Contributor

The copyright header is good as per the discussion and we have covered all the .md and .py files
We can go for this.

@rogpers-ericsson
Copy link

👍

@d-stahl-ericsson d-stahl-ericsson merged commit 935cf3d into eiffel-community:master Apr 11, 2017
@d-stahl-ericsson d-stahl-ericsson deleted the issue130 branch September 13, 2018 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants