Skip to content

Autogenerated files shouldn't contain additional patches #136

@magnusbaeck

Description

@magnusbaeck

Description

The files generated from the schemas have been edited by hand before being committed so regenerating them from the schemas results in a huge diff even if there are no schema changes. Generated files should be committed as-is. There's a related issue with the copyright headers (#133) but let's solve that problem separately and for now and just get the current files to match the generated files, except the copyright header.

Motivation

Updating the files after a schema change should be a simple task that even could be automated. Hand-patching updates is a complete waste of time. If we want files formatted in a particular way (or whatever was the reason behind the patches) we should fix the code generator or automate the patching.

Exemplification

I tried to update the generated files to the Paris edition of the Eiffel protocol and had to spend considerable time going through the diff and the history of the git to understand why the diff was huge.

Benefits

Easier to update the generated files when new protocol changes are made.

Possible Drawbacks

None.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions