Add 3D cluster shape analysis #616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add 3D cluster shape analysis.
for more information, see https://pre-commit.ci
veprbl
reviewed
Apr 19, 2023
Some other minor comments from the PR implemented.
for more information, see https://pre-commit.ci
…es to the returend cluster shape parameters.
veprbl
reviewed
Apr 20, 2023
veprbl
reviewed
Apr 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Briefly, what does this PR introduce?
Cluster shape properties are calculated from the 3D covariance matrix of hits within a cluster.
2 coordinate system options are provided: eta-phi-z and x-y-z, which can be toggled with the m_xyClusterProfiling variable.
This adds to the existing routine, which has been moved out of the header file and into the CalorimeterClusterRecoCoG.cc.
What kind of change does this PR introduce?
Please check if this PR fulfills the following:
Does this PR introduce breaking changes? What changes might users need to make to their code?
Does this PR change default behavior?