Skip to content

Fix Pos,Neg contracts which fail incorrectly for nil values #147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
egonSchiele merged 1 commit into from
May 13, 2015
Merged

Fix Pos,Neg contracts which fail incorrectly for nil values #147

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/contracts/builtin_contracts.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,14 +29,14 @@ def self.valid? val
# Check that an argument is a positive number.
class Pos
def self.valid? val
val > 0
val && val > 0
end
end

# Check that an argument is a negative number.
class Neg
def self.valid? val
val < 0
val && val < 0
end
end

Expand Down
12 changes: 12 additions & 0 deletions spec/builtin_contracts_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,10 @@
it "should fail for negative numbers" do
expect { @o.pos_test(-1) }.to raise_error(ContractError)
end

it "should fail for nil" do
expect { @o.pos_test(nil) }.to raise_error(ContractError)
end
end

describe "Neg:" do
Expand All @@ -43,6 +47,10 @@
it "should fail for positive numbers" do
expect { @o.neg_test(1) }.to raise_error(ContractError)
end

it "should fail for nil" do
expect { @o.neg_test(nil) }.to raise_error(ContractError)
end
end

describe "Nat:" do
Expand All @@ -61,6 +69,10 @@
it "should fail for negative numbers" do
expect { @o.nat_test(-1) }.to raise_error(ContractError)
end

it "should fail for nil" do
expect { @o.nat_test(nil) }.to raise_error(ContractError)
end
end

describe "Any:" do
Expand Down