This repository has been archived by the owner on Jul 6, 2021. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This plugin uses a computed property to infer the
localeName
, which would be fine, except it being used in thedata()
to set the initial value.This causes the first render of the text to be in english (or default language) and not the configured language, after the first update this is corrected.
Not sure this is the best way ™️ to fix this, but it seemed reasonable enough.
Edit: I noticed the
localeName
computed property now only is used in a watcher, which can be removed and used to watch thelocale
prop directly.