-
-
Notifications
You must be signed in to change notification settings - Fork 264
chore: add maintenance info in README #1332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
It feels way too early to pull the plug on this. Rolldown is still in its early days... There are still some major bugs that would be nice to fix to at least leave tsup in a stable state... Such as issues with watch mode not working properly... |
This is not about pulling the plug, just informing about the current state (see linked post). It already is in maintenance mode, just not communicated besides in the tweet. |
|
Yeah... What I mean... it feels very early to already start pushing people towards rolldown/tsdown and going maintenance only on this project... |
sxzz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Permission has already been obtained from @egoist.
Due to egoist/tsup#1332 Migration guide: https://tsdown.dev/guide/migrate-from-tsup Findings: - removes augmentation from DTS if it's not a `.d.ts` file — ~~addressed by renaming~~ addressed using banner and extra entrypoint - does not support imports without extension in config file - does not support importing JSON files without import attributes in config file — addressed by `readFile` - surprisingly keeps the import of a runtime dependency in DTS even if unused (had to patch tsup for that) - dts, cleanup and node protocol — are by default - `attw` is integrated when installed <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Chores** * Switched the project to a new build tool and added corresponding build configurations; removed legacy bundler configs, patches, and related build scripts; bumped package versions and cleaned build-related dependencies. * **Tests** * Updated tests for the new build tooling and added DTS compatibility checks for TypeScript declarations. * **Notes** * No user-facing API or runtime behavior changes expected. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Based on https://x.com/localhost_5173/status/1913448837441806564
@egoist feel free to adapt as needed or close if you think it is not fitting!