-
-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update postcss version to 8 #325
Conversation
Codecov Report
@@ Coverage Diff @@
## master #325 +/- ##
=======================================
Coverage 92.68% 92.68%
=======================================
Files 10 10
Lines 328 328
Branches 115 115
=======================================
Hits 304 304
Misses 23 23
Partials 1 1 Continue to review full report at Codecov.
|
LGTM |
If we move it to peerdependencies, it's a breaking change. You'll have to give us some time to see if we can bundle more breaking changes. |
Hi, I'm curious what the status is? I'm waiting for an update to be released so I can use postcss 8 plugins with this rollup plugin... |
I didn't realize there was a PR and uploaded #335. Mine updates other deps that support postcss 8 and updates test snaps, I think it's probably better in the end. |
Any updates on when this can be merged? Not being able to use postcss-8 over two months down the road is killer. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
🎉 This PR is included in version 4.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This updates the postcss version to 8 and moves the dependency to
peerDependencies
. Tests are all passing, but there are a couple of deprecation warnings.Fixes #324