test: fix doctools path on windows #4090
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fengmk2
commented
Dec 7, 2019
| const cmd = `${doctools} build`; | ||
| console.log('Runing %j on %j', cmd, cwd); | ||
| await runscript(cmd, { cwd }); | ||
| await runscript(`${doctools} build`, { cwd }); |
There was a problem hiding this comment.
终于修复 windows 无法跑 doctools 的问题。是 npminstall 依赖的 npm 的官方包的 bug cnpm/npminstall#317
Codecov Report
@@ Coverage Diff @@
## master #4090 +/- ##
======================================
Coverage 100% 100%
======================================
Files 34 34
Lines 954 954
======================================
Hits 954 954Continue to review full report at Codecov.
|
atian25
approved these changes
Dec 9, 2019
popomore
pushed a commit
that referenced
this pull request
Dec 9, 2019
test: fix doctools path on windows (#4090)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
npm testpassesAffected core subsystem(s)
Description of change