feat: add config.logger.disableConsoleAfterReady #1001
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
let app can change the logger config
Codecov Report
@@ Coverage Diff @@
## master #1001 +/- ##
=======================================
Coverage 98.96% 98.96%
=======================================
Files 28 28
Lines 675 675
=======================================
Hits 668 668
Misses 7 7
Continue to review full report at Codecov.
|
dead-horse
reviewed
Jun 6, 2017
| @@ -213,6 +214,7 @@ module.exports = appInfo => { | |||
| env: appInfo.env, | |||
| level: 'INFO', | |||
| consoleLevel: 'INFO', | |||
| disableConsoleAfterReady: appInfo.env !== 'local' && appInfo.env !== 'unittest', | |||
There was a problem hiding this comment.
恩，就在 env 章节写从 app.config.env 获取好了。
|
logger 真是个复杂的东西。 |
|
@popomore @dead-horse 可以合并了？ |
dead-horse
approved these changes
Jun 8, 2017
popomore
approved these changes
Jun 8, 2017
|
再重跑下 ci |
1) test/lib/plugins/development.test.js reload workers should reload when file changed:
AssertionError: should match stdout expected `/app_worker#2:\d+ started/(RegExp)` but actual `2017-06-09 05:21:20,641 INFO 3946 [master] egg version 1.4.0\n2017-06-09 05:21:21,139 INFO 3946 [master] agent_worker#1:3952 started (489ms)\n2017-06-09 05:21:21,870 INFO 3946 [master] egg started on http://127.0.0.1:17024 (1227ms)\n2017-06-09 05:21:22,123 WARN 3952 [agent:development] reload worker because /home/travis/build/eggjs/egg/test/fixtures/apps/reload-worker/app/controller/home.js change\n2017-06-09 05:21:22,807 INFO 3946 [master] app_worker#1:3962 disconnect, suicide: true, state: disconnected, current workers: ["2"]\n(String)`
+ expected - actual
-false
+true |
|
在这里解决 #1022 (comment) |
|
继续重跑 |
|
要发版本么 |
|
先不发，等需要发版本的时候带出去 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
let app can change the logger config
Checklist
npm testpassesAffected core subsystem(s)
Description of change