feat: support ts filter #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #27 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 9 9
Lines 87 91 +4
=====================================
+ Hits 87 91 +4
Continue to review full report at Codecov.
|
28 tasks
popomore
reviewed
Mar 29, 2018
| @@ -61,7 +61,8 @@ class NunjucksEnvironment extends nunjucks.Environment { | |||
| // load `app/extend/filter.js` from app/framework/plugin into nunjucks | |||
| [LOAD_FILTER]() { | |||
| for (const unit of this.app.loader.getLoadUnits()) { | |||
| const filterPath = path.join(unit.path, 'app/extend/filter.js'); | |||
| const filterPath = resolveModule(path.join(unit.path, 'app/extend/filter')); | |||
popomore
approved these changes
Mar 29, 2018
|
@atian25 你来发吧 |
|
2.2.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
npm testpassesAffected core subsystem(s)
Description of change
这个库现在还要支持 egg@1 ，比较简单就没加 ts 后缀的测试。