Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix declaration merging error #86

Merged
merged 2 commits into from
Aug 24, 2018
Merged

fix: fix declaration merging error #86

merged 2 commits into from
Aug 24, 2018

Conversation

whxaxes
Copy link
Member

@whxaxes whxaxes commented Aug 24, 2018

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change

发现通过 declaration merging 的 override 方式还是有问题,会导致 export 出去的就只剩了一个 restore 方法,把原来的 EggMock 覆盖掉了,改回 restore: () => any

@whxaxes
Copy link
Member Author

whxaxes commented Aug 24, 2018

@paranoidjk 貌似我错了.... declaration merging 不能绕过 override 的问题

@dead-horse dead-horse merged commit 00fb82e into master Aug 24, 2018
@dead-horse dead-horse deleted the fix-typings branch August 24, 2018 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants