Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support ts #70

Merged
merged 1 commit into from
Mar 28, 2018
Merged

feat: support ts #70

merged 1 commit into from
Mar 28, 2018

Conversation

atian25
Copy link
Member

@atian25 atian25 commented Mar 27, 2018

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change

@atian25 atian25 requested a review from popomore March 27, 2018 00:44
@atian25 atian25 force-pushed the typescript branch 2 times, most recently from 8487c7b to 1963eda Compare March 27, 2018 00:50
@codecov
Copy link

codecov bot commented Mar 27, 2018

Codecov Report

Merging #70 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #70      +/-   ##
==========================================
+ Coverage   94.88%   94.89%   +<.01%     
==========================================
  Files          12       12              
  Lines         587      588       +1     
==========================================
+ Hits          557      558       +1     
  Misses         30       30
Impacted Files Coverage Δ
lib/cluster.js 92.59% <ø> (ø) ⬆️
bootstrap.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 41e73a1...f0f12f1. Read the comment docs.

@atian25 atian25 force-pushed the typescript branch 2 times, most recently from e661ee7 to c638ffc Compare March 27, 2018 06:12
@@ -14,20 +17,27 @@ describe('test/mock_context.test.js', () => {
after(() => app.close());
afterEach(mm.restore);

it('should work on GET with user login', () => {
it.only('should work on GET with user login', async () => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only 这个

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

故意的,我正在看这个在 win 的报错。

@atian25 atian25 force-pushed the typescript branch 5 times, most recently from 5f628c1 to 9f05376 Compare March 27, 2018 09:26
@atian25
Copy link
Member Author

atian25 commented Mar 27, 2018

@popomore 再看看这个。 win 那个问题搞不懂,跟这个 PR 无关。

@atian25
Copy link
Member Author

atian25 commented Mar 28, 2018

先合了,win 那个跟这个 PR 无关,再看。

@atian25 atian25 merged commit fb30181 into master Mar 28, 2018
@atian25 atian25 deleted the typescript branch March 28, 2018 00:01
@atian25
Copy link
Member Author

atian25 commented Mar 28, 2018

3.16.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants