Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add EGG_HOME to getHomedir for test #25

Merged
merged 1 commit into from
Oct 24, 2016
Merged

Conversation

popomore
Copy link
Member

@popomore popomore commented Oct 24, 2016

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change

Use process.env.EGG_HOME to mock home

Ref eggjs/egg#129

Use process.env.EGG_HOME to mock `home`

Ref eggjs/egg#129
@mention-bot
Copy link

@popomore, thanks for your PR! By analyzing the history of the files in this pull request, we identified @ngot and @gxcsoccer to be potential reviewers.

@codecov-io
Copy link

Current coverage is 99.83% (diff: 100%)

Merging #25 into master will not change coverage

@@             master        #25   diff @@
==========================================
  Files            16         16          
  Lines           622        622          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits            621        621          
  Misses            1          1          
  Partials          0          0          

Powered by Codecov. Last update afca35a...e5d2b41

@dead-horse
Copy link
Member

+1

@dead-horse dead-horse merged commit 023007c into master Oct 24, 2016
@dead-horse dead-horse deleted the env-egg-home branch October 24, 2016 10:41
@popomore
Copy link
Member Author

@popomore popomore mentioned this pull request Nov 2, 2016
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants