feat: revert egg-bin check (#90)

eggjs · Mar 26, 2018 · 83322e6 · 83322e6
1 parent 3bf9b72
commit 83322e6
Show file tree

Hide file tree

Showing 13 changed files with 4 additions and 122 deletions.
diff --git a/.autod.conf b/.autod.conf
@@ -14,8 +14,6 @@ module.exports = {
     'intelli-espower-loader',
     'power-assert',
     'ypkgfiles',
-    'eslint-plugin-eggache',
-    'eslint',
   ],
   devdep: [
     'autod',

diff --git a/.eslintignore b/.eslintignore
@@ -1,4 +1,3 @@
 node_modules/
 coverage/
 test/fixtures/enzyme-example-mocha/
-test/fixtures/check-eggache/
diff --git a/README.md b/README.md
@@ -192,16 +192,6 @@ Generate `pkg.dependencies` and `pkg.devDependencies` automatically, see [autod]
 $ egg-bin autod
 ```
 
-## check
-
-Check egg project for collect useful infomation to report issue.
-
-```bash
-$ egg-bin check
-```
-### Rules:
-- [eslint-plugin-eggache](https://github.com/eggjs/eslint-plugin-eggache)
-
 ## Custom egg-bin for your team
 
 You maybe need a custom egg-bin to implement more custom features if your team has develop a framework base on egg.

diff --git a/lib/check-eslintrc b/lib/check-eslintrc
diff --git a/lib/cmd/check.js b/lib/cmd/check.js
diff --git a/package.json b/package.json
@@ -15,8 +15,6 @@
     "debug": "^3.1.0",
     "detect-port": "^1.2.2",
     "egg-utils": "^2.3.0",
-    "eslint": "^4.18.1",
-    "eslint-plugin-eggache": "^1.0.0",
     "globby": "^8.0.1",
     "inspector-proxy": "^1.2.1",
     "intelli-espower-loader": "^1.0.1",

diff --git a/test/fixtures/check-eggache/config/config.default.js b/test/fixtures/check-eggache/config/config.default.js
diff --git a/test/fixtures/check-eggache/config/plugin.js b/test/fixtures/check-eggache/config/plugin.js
diff --git a/test/fixtures/check-eggache/other.js b/test/fixtures/check-eggache/other.js
diff --git a/test/fixtures/check-eggache/package.json b/test/fixtures/check-eggache/package.json
diff --git a/test/lib/cmd/autod.test.js b/test/lib/cmd/autod.test.js
@@ -18,9 +18,9 @@ describe('test/lib/cmd/autod.test.js', () => {
   it('should autod check fail', function* () {
     const cwd = path.join(__dirname, '../../fixtures/autod-missing');
     yield coffee.fork(eggBin, [ 'autod', '--check' ], { cwd })
-      // .debug()
+      .debug()
       .expect('code', 1)
-      .expect('stderr', /\[ERROR\] Missing dependencies: \["urllib"\]/)
+      .expect('stderr', /\[ERROR\].*Missing dependencies: \["urllib"\]/)
       .end();
   });
 

diff --git a/test/lib/cmd/check.test.js b/test/lib/cmd/check.test.js
diff --git a/test/lib/cmd/cov.test.js b/test/lib/cmd/cov.test.js
@@ -5,11 +5,13 @@ const path = require('path');
 const assert = require('assert');
 const coffee = require('coffee');
 const mm = require('mm');
+const rimraf = require('mz-modules/rimraf');
 
 describe('test/lib/cmd/cov.test.js', () => {
   const eggBin = require.resolve('../../../bin/egg-bin.js');
   const cwd = path.join(__dirname, '../../fixtures/test-files');
 
+  beforeEach(() => rimraf(path.join(cwd, 'coverage')));
   afterEach(mm.restore);
 
   it('should success', done => {