Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement checker #165

Closed
wants to merge 2 commits into from
Closed

feat: implement checker #165

wants to merge 2 commits into from

Conversation

killagu
Copy link
Contributor

@killagu killagu commented May 16, 2018

implement checker loader, load app/checker.
Checkers will be called after all readyCallbacks called,
then emit app.ready(true).

Refs: eggjs/egg#2520

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

core: loader

Description of change

implement checker loader, load `app/checker`.
Checkers will be called after all readyCallbacks called,
then emit `app.ready(true)`.

Refs: eggjs/egg#2520
@killagu killagu requested a review from popomore May 16, 2018 07:04
@codecov
Copy link

codecov bot commented May 16, 2018

Codecov Report

Merging #165 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #165   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          17     19    +2     
  Lines         894    937   +43     
=====================================
+ Hits          894    937   +43
Impacted Files Coverage Δ
lib/loader/egg_loader.js 100% <ø> (ø) ⬆️
lib/loader/mixin/checker.js 100% <100%> (ø)
lib/utils/base_checker_class.js 100% <100%> (ø)
index.js 100% <100%> (ø) ⬆️
lib/egg.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a43dcb9...fa525d3. Read the comment docs.

@popomore popomore closed this Jul 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants