Skip to content

Conversation

@ErikEJ
Copy link
Member

@ErikEJ ErikEJ commented Sep 15, 2025

fixes #331

@ErikEJ
Copy link
Member Author

ErikEJ commented Sep 15, 2025

@roji FYI

@ErikEJ ErikEJ requested review from Copilot and roji September 15, 2025 18:55
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes the .NET SDK version configuration by correcting an invalid version number and updating the GitHub workflow to rely on the global.json file for SDK version specification.

  • Updates the SDK version from an invalid format to a proper .NET 10 release candidate version
  • Removes explicit SDK version specification from the GitHub workflow to use global.json instead

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
global.json Corrects invalid SDK version number from "10.0.0" to "10.0.100"
.github/workflows/build.yml Removes explicit dotnet-version to use global.json configuration

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Member

@roji roji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yes, makes sense...

@ErikEJ ErikEJ merged commit 55e091c into efcore:main Sep 15, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove SDK version from pipeline

2 participants