-
Notifications
You must be signed in to change notification settings - Fork 92
Fix SDK version #333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix SDK version #333
Conversation
|
@roji FYI |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes the .NET SDK version configuration by correcting an invalid version number and updating the GitHub workflow to rely on the global.json file for SDK version specification.
- Updates the SDK version from an invalid format to a proper .NET 10 release candidate version
- Removes explicit SDK version specification from the GitHub workflow to use global.json instead
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| global.json | Corrects invalid SDK version number from "10.0.0" to "10.0.100" |
| .github/workflows/build.yml | Removes explicit dotnet-version to use global.json configuration |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
roji
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah yes, makes sense...
fixes #331