downgrading source-map-url #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Version 0.4.0 introduces a feature that tries to look for URLs in non-terminal position, but the regex is too broad and it can result in syntax errors.
|
can you add a test for this, so it doesn't get bumped again in the future when we forget? |
|
Yeah, that or I will fix upstream, and adopt if the maintainer isn't around (no idea -- the package hasn't been touched, but that could just be because it's simple and stable). |
|
My use case is slightly weird: the sourceMap url that's getting broken is inside an |
This was referenced Aug 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version 0.4.0 introduces a feature that tries to look for URLs in non-terminal position, but the regex is too broad and it can result in syntax errors.
The upstream package hasn't been touched in three years, and we've been relying on 0.3.0 for a long time, so I think it's safe to just go back to that.