[perf/stringify]: Use a Map for prevObjects in createNode #137
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the
Array.find
method forprevObjects
seems to be a serious bottleneck in thestringify
method (src/schema/index
createNode
method).On a 14Mb YAML file, with this change, time to run
stringify
dropped from around 4 minutes to 4 seconds on my machine.I get the same test results before and after.