Skip to content

Commit

Permalink
Use image density from fetch in the processing model
Browse files Browse the repository at this point in the history
  • Loading branch information
eeeps committed Nov 23, 2019
1 parent 992c138 commit a1ba23a
Showing 1 changed file with 12 additions and 0 deletions.
12 changes: 12 additions & 0 deletions source
Original file line number Diff line number Diff line change
Expand Up @@ -2798,6 +2798,7 @@ a.setAttribute('href', 'https://example.com/'); // change the content attribute
<li><dfn data-x="concept-internal-response" data-x-href="https://fetch.spec.whatwg.org/#concept-internal-response">internal response</dfn></li>
<li><dfn data-x="concept-response-csp-list" data-x-href="https://fetch.spec.whatwg.org/#concept-response-csp-list">CSP list</dfn></li>
<li><dfn data-x="concept-response-https-state" data-x-href="https://fetch.spec.whatwg.org/#concept-response-https-state">HTTPS state</dfn></li>
<li><dfn data-x="concept-response-location-url" data-x-href="https://fetch.spec.whatwg.org/#concept-response-image-density"><!--TODO(eeeps) hook this up to the PR-->image density</dfn></li>
<li><dfn data-x="concept-response-location-url" data-x-href="https://fetch.spec.whatwg.org/#concept-response-location-url">location URL</dfn></li>
</ul>
</li>
Expand Down Expand Up @@ -28056,6 +28057,17 @@ was an English &lt;a href="/wiki/Music_hall">music hall&lt;/a> singer, ...</code
<li><p>End the <span>synchronous section</span>, continuing the remaining steps <span>in
parallel</span>, but without missing any data from fetching.</p></li>

<li>

<p>If the fetch’s response has an

This comment has been minimized.

Copy link
@zcorpan

zcorpan Nov 23, 2019

There's no response yet, I think. Maybe add a step to wait until there is a response or an error. @annevk can maybe help with getting this right, I'm not certain about how to interface with fetch correctly.

Also, don't set state that can be observed by JS in parallel (you generally queue a task to do so).

<span data-x="concept-response-image-density">image density</span>, set
<span>image request</span>’s <span>current pixel density</span> to
<span data-x="concept-image-density">image density</span>.</p>

</li>

</li>

<li>

<p>As soon as possible, jump to the first applicable entry from the following list:</p>
Expand Down

0 comments on commit a1ba23a

Please sign in to comment.