chore: wrap truncate/insert in a transaction. #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pwnage101
approved these changes
Jul 29, 2022
Comment on lines
+32
to
+35
| "begin", | ||
| "truncate table", | ||
| "insert into", | ||
| "commit", |
There was a problem hiding this comment.
Yes, now it's part of the compiled sql.
Comment on lines
-122
to
+126
| {{ run_hooks(post_hooks, inside_transaction=True) }} | ||
|
|
||
| -- `COMMIT` happens here | ||
| {{ adapter.commit() }} | ||
|
|
||
| {{ run_hooks(post_hooks, inside_transaction=False) }} | ||
| {{ run_hooks(post_hooks) }} |
There was a problem hiding this comment.
Interesting that this now reverses the order of post_hooks & commit. Beforehand, the commit happened after post_hooks, but now it happens before post_hooks. I would guess the new behavior is more correct anyway.
HassanJaveed84
force-pushed
the
hassan/fix-transaction-issue
branch
from
8ceb752 to
7ef6952
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting with release 0.21.0 of dbt(dbt-labs/dbt-core#3510), transactions were turned off and autocommit has been turned on.
This re-enables transactions for our custom materialization by wrapping truncate/insert in a begin/commit.
The integration tests passed, also confirmed visually by viewing query history:
